wgsl: Implement AbstractInt complement (~) execution tests #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-clayton
reviewed
Feb 28, 2024
| import { fullI64Range } from '../../../../util/math.js'; | ||
| import { makeCaseCache } from '../case_cache.js'; | ||
|
|
||
| export const d = makeCaseCache('unary/ai_complement', { |
There was a problem hiding this comment.
Having a case cache for integer tests like this seems like it would be a pessimism. I would strongly suspect that the overhead for deserializing these cases would far outweigh the cost of runtime generation.
There was a problem hiding this comment.
The existing integer complement tests use this pattern. Should I convert them away from using the cache too?
There was a problem hiding this comment.
Given that there's no heavy interval logic being precomputed, that seems like a good idea.
zoddicus
force-pushed
the
addAbstractIntComplementExecutionTests
branch
from
89c9c13 to
37cf5d2
Compare
ben-clayton
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1631
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.