Add service worker support #3419

beaufortfrancois · 2024-02-19T16:14:36Z

Spec PR: gpuweb/gpuweb#4465

Requirements for PR author:

All missing test coverage is tracked with "TODO" or .unimplemented().
New helpers are /** documented */ and new helper files are found in helper_index.txt.
Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

Tests are properly located in the test tree.
Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

src/common/tools/gen_listings_and_webworkers.ts

beaufortfrancois · 2024-03-04T13:40:42Z

@kainino0x After many efforts, I was able to get them working. /me happy!

I'll appreciate your review as I had to take corners due to my unfamiliarity with the WebGPU CTS infrastructure.

kainino0x · 2024-03-05T03:12:11Z

Nice!! Sorry, I ended up with a lot of code reviewing to do today. I will review soon.

kainino0x

This looks great so far, not too complex!

src/common/runtime/helper/test_worker.ts

src/common/tools/dev_server.ts

src/common/tools/gen_listings_and_webworkers.ts

src/webgpu/web_platform/worker/worker.spec.ts

beaufortfrancois

Thank you @kainino0x for the review!

src/common/tools/dev_server.ts

src/webgpu/web_platform/worker/worker.spec.ts

src/common/runtime/helper/test_worker.ts

src/common/tools/gen_listings_and_webworkers.ts

src/common/tools/dev_server.ts

This will be needed to launch Service Workers, which cannot be generated at runtime and cannot use dynamic import().

kainino0x · 2024-03-06T18:32:45Z

nit: Avoid force-pushing: https://github.com/gpuweb/cts/blob/main/docs/intro/developing.md#pull-requests

src/common/internal/query/compare.ts

beaufortfrancois · 2024-03-06T20:07:29Z

nit: Avoid force-pushing: https://github.com/gpuweb/cts/blob/main/docs/intro/developing.md#pull-requests

I will be more vigilant in the future. Sorry for that.

kainino0x · 2024-03-06T20:31:12Z

All good! Left one more comment.

src/common/tools/gen_listings_and_webworkers.ts

src/common/tools/dev_server.ts

src/common/runtime/helper/test_worker.ts

src/common/tools/dev_server.ts

src/common/runtime/helper/test_worker.ts

DedicatedWorker can be created from DedicatedWorker, but none of the other nested worker pairs are allowed.

src/common/runtime/helper/test_worker.ts

kainino0x · 2024-03-08T00:55:43Z

@beaufortfrancois I pushed some commits polishing up some bits. Please review, then this should be ready to squash-and-merge!

beaufortfrancois · 2024-03-08T08:32:53Z

@kainino0x Everything but #3419 (comment) looks good to me. Thank you for polishing this PR!

src/common/runtime/helper/wrap_for_worker.ts

beaufortfrancois · 2024-03-11T19:14:45Z

@kainino0x I think we're good to merge now. I'll let you do it.

beaufortfrancois · 2024-03-12T08:50:58Z

@kainino0x Thank you!

* Generate Web Worker script for every test file This will be needed to launch Service Workers, which cannot be generated at runtime and cannot use dynamic import(). * Add service worker support * Update wpt.ts * Run tests * Address kainino0x feedback * Address feedback | part 2 * Address feedback | part 3 * Address feedback | part 4 * Address feedback | part 5 * Address feedback | part 6 * Address feedback | part 7 * Address feedback | part 8 * Apply suggestions from code review * use WorkerTestRunRequest in the postMessage/onmessage interface * Clean up resolvers map * Use express routing for .worker.js * Skip worker tests when run in a worker that can't support them DedicatedWorker can be created from DedicatedWorker, but none of the other nested worker pairs are allowed. * Clean up all service workers on startup and shutdown * Avoid reinitializing service workers for every single case * lint fixes * Catch errors in wrapTestGroupForWorker onMessage * Make sure the service worker has the correct URL --------- Co-authored-by: Kai Ninomiya <[email protected]>

beaufortfrancois marked this pull request as draft February 19, 2024 16:14

beaufortfrancois mentioned this pull request Feb 19, 2024

Add shared worker support #3345

Merged

7 tasks

beaufortfrancois force-pushed the service-worker branch from 2d441f8 to 7b74efd Compare February 20, 2024 13:50

beaufortfrancois commented Feb 20, 2024

View reviewed changes

src/common/tools/gen_listings_and_webworkers.ts Outdated Show resolved Hide resolved

greggman force-pushed the shared-worker branch from d4a925c to 4641deb Compare February 21, 2024 15:31

Base automatically changed from shared-worker to main February 21, 2024 15:35

beaufortfrancois force-pushed the service-worker branch 5 times, most recently from 6057e70 to 7a96c3c Compare March 4, 2024 13:35

beaufortfrancois marked this pull request as ready for review March 4, 2024 13:38

kainino0x reviewed Mar 6, 2024

View reviewed changes

beaufortfrancois commented Mar 6, 2024

View reviewed changes

beaufortfrancois force-pushed the service-worker branch from 4116482 to 0bb2ce0 Compare March 6, 2024 12:41

kainino0x and others added 5 commits March 6, 2024 13:44

Generate Web Worker script for every test file

fec22b7

This will be needed to launch Service Workers, which cannot be generated at runtime and cannot use dynamic import().

Add service worker support

533afe4

Update wpt.ts

20444d0

Run tests

23f0a47

Address kainino0x feedback

675f6ad

beaufortfrancois force-pushed the service-worker branch from 0bb2ce0 to 675f6ad Compare March 6, 2024 12:44

kainino0x reviewed Mar 6, 2024

View reviewed changes

src/common/internal/query/compare.ts Show resolved Hide resolved

Address feedback | part 2

5d0e4c0

Address feedback | part 3

4ea5270

kainino0x reviewed Mar 6, 2024

View reviewed changes

src/common/tools/gen_listings_and_webworkers.ts Outdated Show resolved Hide resolved

src/common/tools/dev_server.ts Outdated Show resolved Hide resolved

Apply suggestions from code review

8730e55

kainino0x reviewed Mar 7, 2024

View reviewed changes

src/common/runtime/helper/test_worker.ts Outdated Show resolved Hide resolved

kainino0x reviewed Mar 7, 2024

View reviewed changes

src/common/tools/dev_server.ts Outdated Show resolved Hide resolved

kainino0x reviewed Mar 7, 2024

View reviewed changes

src/common/runtime/helper/test_worker.ts Outdated Show resolved Hide resolved

kainino0x added 4 commits March 7, 2024 15:45

use WorkerTestRunRequest in the postMessage/onmessage interface

ffff9fd

Clean up resolvers map

4d78304

Use express routing for .worker.js

0571de7

Skip worker tests when run in a worker that can't support them

465dd64

DedicatedWorker can be created from DedicatedWorker, but none of the other nested worker pairs are allowed.

kainino0x reviewed Mar 8, 2024

View reviewed changes

src/common/runtime/helper/test_worker.ts Outdated Show resolved Hide resolved

kainino0x added 4 commits March 7, 2024 16:44

Clean up all service workers on startup and shutdown

d66ce41

Avoid reinitializing service workers for every single case

01f8b22

Merge branch 'main' into service-worker

d03d129

lint fixes

5eb75c3

kainino0x added 3 commits March 8, 2024 14:29

Merge branch 'main' into service-worker

749ee9c

Catch errors in wrapTestGroupForWorker onMessage

4c8178f

Make sure the service worker has the correct URL

97e378e

kainino0x force-pushed the service-worker branch from 85d764a to 97e378e Compare March 8, 2024 22:30

beaufortfrancois commented Mar 9, 2024

View reviewed changes

src/common/runtime/helper/wrap_for_worker.ts Show resolved Hide resolved

Merge branch 'main' into service-worker

53173a5

kainino0x enabled auto-merge (squash) March 11, 2024 19:51

kainino0x merged commit 5ad7589 into main Mar 11, 2024
1 check passed

kainino0x deleted the service-worker branch March 11, 2024 19:54

kainino0x mentioned this pull request Mar 29, 2024

Generate Web Worker script for every test file #3415

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add service worker support #3419

Add service worker support #3419

beaufortfrancois commented Feb 19, 2024 •

edited by kainino0x

Loading

beaufortfrancois commented Mar 4, 2024

kainino0x commented Mar 5, 2024

kainino0x left a comment

beaufortfrancois left a comment

kainino0x commented Mar 6, 2024

beaufortfrancois commented Mar 6, 2024

kainino0x commented Mar 6, 2024

kainino0x commented Mar 8, 2024

beaufortfrancois commented Mar 8, 2024 •

edited

Loading

beaufortfrancois commented Mar 11, 2024

beaufortfrancois commented Mar 12, 2024

Add service worker support #3419

Add service worker support #3419

Conversation

beaufortfrancois commented Feb 19, 2024 • edited by kainino0x Loading

beaufortfrancois commented Mar 4, 2024

kainino0x commented Mar 5, 2024

kainino0x left a comment

Choose a reason for hiding this comment

beaufortfrancois left a comment

Choose a reason for hiding this comment

kainino0x commented Mar 6, 2024

beaufortfrancois commented Mar 6, 2024

kainino0x commented Mar 6, 2024

kainino0x commented Mar 8, 2024

beaufortfrancois commented Mar 8, 2024 • edited Loading

beaufortfrancois commented Mar 11, 2024

beaufortfrancois commented Mar 12, 2024

beaufortfrancois commented Feb 19, 2024 •

edited by kainino0x

Loading

beaufortfrancois commented Mar 8, 2024 •

edited

Loading