Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation tests for unary address-of and indirection #3410

Merged

Conversation

amaiorano
Copy link
Member

Issue: #3225


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@amaiorano amaiorano force-pushed the address-of-and-indirection-validation-tests branch 3 times, most recently from eb97972 to 16bfb60 Compare February 15, 2024 22:10
@amaiorano amaiorano force-pushed the address-of-and-indirection-validation-tests branch from 16bfb60 to 3724a4a Compare February 16, 2024 17:04
@amaiorano amaiorano force-pushed the address-of-and-indirection-validation-tests branch from 3724a4a to 2d9fe6e Compare February 16, 2024 18:28
@amaiorano amaiorano merged commit a60062b into gpuweb:main Feb 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants