Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate tests for target format supporting usage and being a color format #3393

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Feb 13, 2024

This splits two logically separate tests that were part of the same test before. This will make it easier to fix usage of the texture info table: Previously, it would access certain members of the info table assuming they were color, but would actually get the depth component of depth and depth-stencil formats. This wasn't really a problem because those formats were already expected to fail. But cleaner to instead just scope that test to only color formats.

Part 4 of Issue: #2495


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@kainino0x kainino0x marked this pull request as ready for review February 13, 2024 02:59
@kainino0x kainino0x requested a review from lokokung February 13, 2024 02:59
@kainino0x kainino0x enabled auto-merge (squash) February 13, 2024 21:25
@kainino0x kainino0x disabled auto-merge February 13, 2024 21:48
@kainino0x kainino0x enabled auto-merge (squash) February 13, 2024 21:55
@kainino0x kainino0x merged commit 559c806 into gpuweb:main Feb 13, 2024
1 check passed
@kainino0x kainino0x deleted the textureinfo2part4 branch February 13, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants