Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maxBindGroupsPlusVertexBuffers test #3377

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Feb 8, 2024

I think this works now. I tested by hacking up the CTS to force a lower limit that Chrome could test

see: https://gist.github.com/greggman/c3c56b8d53174453df166a5a2383b1c3#maxbindgroupsplusvertexbuffers

I also changed it so it can test at limit tests (vs over limit tests). This should mean some tests run on browsers where maxBindGroups + maxVertexBuffers === maxBindGroupsPlusVertexBuffers.

Hopefully it's correct now.

Issue: #3376


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@greggman greggman requested a review from mwyrzykowski February 8, 2024 18:50
I think this works now. I tested by hacking up the CTS to force a lower
limit that Chrome could test

see: https://gist.github.com/greggman/c3c56b8d53174453df166a5a2383b1c3#maxbindgroupsplusvertexbuffers

I also changed it so it can test at limit tests (vs over limit tests).
This should mean some tests run on browsers where maxBindGroups +
maxVertexBuffers === maxBindGroupsPlusVertexBuffers.
@greggman greggman force-pushed the fix-maxBindGroupsPlusVertexBuffers branch from dd80a46 to cfec91d Compare February 9, 2024 20:38
@greggman greggman enabled auto-merge (squash) February 9, 2024 20:38
@greggman greggman merged commit 2fdb8e5 into gpuweb:main Feb 9, 2024
1 check passed
@greggman greggman deleted the fix-maxBindGroupsPlusVertexBuffers branch February 9, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants