Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bitcast of AFloat to F32 tests to allow FTZ #3373

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

amaiorano
Copy link
Member

@amaiorano amaiorano commented Feb 7, 2024

These tests were failing CTS on Windows when using FXC, which converts subnormal literals to 0.

Issue: #3325


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@amaiorano amaiorano requested a review from zoddicus February 7, 2024 21:59
These tests were failing CTS on Windows when using FXC, which converts
subnormal literals to 0.
@amaiorano amaiorano force-pushed the fix-bitcast-afloat-to-f32-ftz branch from 02488fc to b6b7296 Compare February 8, 2024 14:58
@amaiorano amaiorano enabled auto-merge (squash) February 8, 2024 15:02
@amaiorano amaiorano merged commit 3f04968 into gpuweb:main Feb 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants