Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Add trivial execution test for each shader stage #3343

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

dneto0
Copy link
Contributor

@dneto0 dneto0 commented Jan 27, 2024


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@dneto0 dneto0 requested a review from dj2 January 27, 2024 00:46
@dneto0 dneto0 force-pushed the trivial-stage-execution branch from 62ff55b to 8045d25 Compare January 29, 2024 20:55
@dneto0 dneto0 enabled auto-merge (squash) January 29, 2024 20:55
@dneto0 dneto0 merged commit 1969f84 into gpuweb:main Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants