Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend compute pass multisampled copy texture helper to copy multiple pixels #3340

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

shrekshao
Copy link
Contributor

@shrekshao shrekshao commented Jan 26, 2024

MAINTAINENCE_TODO: Extend the copySinglePixelTextureToBufferUsingComputePass to copy2DTextureToBufferUsingComputePass for copying multiple texels for multisampled texture.

This is to support sampleCount=4 for texture/write test in #3333


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@shrekshao shrekshao requested a review from kainino0x January 26, 2024 22:47
src/webgpu/gpu_test.ts Outdated Show resolved Hide resolved
src/webgpu/gpu_test.ts Outdated Show resolved Hide resolved
src/webgpu/gpu_test.ts Outdated Show resolved Hide resolved
@shrekshao shrekshao force-pushed the multisample-copy-pr branch from 5e9f0c9 to ef113bf Compare January 29, 2024 20:24
@shrekshao shrekshao enabled auto-merge (squash) January 29, 2024 22:31
@shrekshao shrekshao merged commit 78959c7 into gpuweb:main Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants