Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add barrier sync tests using workgroupUniformLoad #3336

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

alan-baker
Copy link
Contributor

  • Add variants of barrier synchronization tests that use workgroupUniformLoad purely as a workgroupBarrier
    • an unrelated placeholder workgroup variable is added in those cases and the value read is unused

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@alan-baker alan-baker requested a review from dneto0 January 26, 2024 18:53
Copy link
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the hold in coverage!

* Add variants of barrier synchronization tests that use
  workgroupUniformLoad purely as a workgroupBarrier
  * an unrelated placeholder workgroup variable is added in those cases
    and the value read is unused
@alan-baker alan-baker enabled auto-merge (squash) January 29, 2024 15:29
@alan-baker alan-baker merged commit 4b8cec0 into gpuweb:main Jan 29, 2024
1 check passed
@alan-baker alan-baker deleted the wul-barrier-sync branch January 29, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants