Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Implement handling AbstractInts as output from tests #3331

Merged
merged 4 commits into from
Jan 30, 2024

Conversation

zoddicus
Copy link
Contributor

Fixes #3302


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@zoddicus zoddicus added the wgsl label Jan 25, 2024
@zoddicus zoddicus self-assigned this Jan 25, 2024
@zoddicus
Copy link
Contributor Author

PTAL

@zoddicus zoddicus force-pushed the addAbstractIntOutputs branch from 1970cef to 38ffa9e Compare January 29, 2024 19:22
src/webgpu/util/conversion.ts Outdated Show resolved Hide resolved
@zoddicus zoddicus force-pushed the addAbstractIntOutputs branch from 38ffa9e to b9d3566 Compare January 30, 2024 18:34
@zoddicus zoddicus merged commit 6a03fa0 into gpuweb:main Jan 30, 2024
1 check passed
@zoddicus zoddicus deleted the addAbstractIntOutputs branch January 30, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make AbstractInts Go.
2 participants