Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AbstractFloat bitcast execution tests. #3299

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Add AbstractFloat bitcast execution tests. #3299

merged 6 commits into from
Jan 23, 2024

Conversation

dj2
Copy link
Member

@dj2 dj2 commented Jan 22, 2024

This CL adds tests for the bitcasting of abstract float values. This includes:

  • abstract float to f32
  • abstract float to vec2
  • vec2 to vec4

Stubs are added for the equivalent AbstractInt tests.

Issue: #1609


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

This CL adds tests for the bitcasting of abstract float values. This
includes:
 * abstract float to f32
 * abstract float to vec2<f16>
 * vec2<abstract-float> to vec4<f16>

Stubs are added for the equivalent AbstractInt tests.
@dj2 dj2 added the wgsl label Jan 22, 2024
@dj2 dj2 requested review from zoddicus and ben-clayton January 22, 2024 22:31
@dj2 dj2 self-assigned this Jan 22, 2024
@dj2 dj2 requested review from zoddicus and ben-clayton January 23, 2024 18:05
@dj2 dj2 merged commit c7e1a4f into gpuweb:main Jan 23, 2024
1 check passed
@dj2 dj2 deleted the af branch January 23, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants