Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: @size only allowed on creation-fixed types #3296

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

jrprice
Copy link
Contributor

@jrprice jrprice commented Jan 22, 2024

Fixes #1715


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@jrprice jrprice added the wgsl label Jan 22, 2024
@jrprice jrprice requested review from zoddicus and dneto0 January 22, 2024 18:56
@zoddicus zoddicus self-requested a review January 22, 2024 20:03
@jrprice jrprice force-pushed the size-creation-fixed branch from a93ec1d to 6d0a287 Compare January 24, 2024 00:05
@jrprice jrprice force-pushed the size-creation-fixed branch from 6d0a287 to 07f5860 Compare January 24, 2024 15:30
@jrprice jrprice merged commit b7ccf04 into gpuweb:main Jan 24, 2024
1 check passed
@jrprice jrprice deleted the size-creation-fixed branch January 24, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wgsl: @size attrib only applies to struct members with creation-fixed footprint
2 participants