Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for workgroup_size execution #3295

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

alan-baker
Copy link
Contributor

  • Checks multidimensional WGs execute the correct number of invocations across multiple workgroups
    • Runs a vareity of sizes up to the listed limits in the API spec and skips invalid combinations
    • Individual dimensions and total number of invocations are checked

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Copy link
Contributor

@zoddicus zoddicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

* Checks multidimensional WGs execute the correct number of invocations
  across multiple workgroups
  * Runs a vareity of sizes up to the listed limits in the API spec and
    skips invalid combinations
  * Individual dimensions and total number of invocations are checked
@alan-baker alan-baker merged commit 206f45e into gpuweb:main Jan 22, 2024
1 check passed
@alan-baker alan-baker deleted the shader-exec-wgsize branch January 22, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants