Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Add floor validation tests #3284

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

zoddicus
Copy link
Contributor

Fixes #3283


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@zoddicus zoddicus added the wgsl label Jan 18, 2024
@zoddicus zoddicus self-assigned this Jan 18, 2024
@zoddicus
Copy link
Contributor Author

PTAL, based off of the ceil tests

@zoddicus zoddicus force-pushed the addFloorValidationTests branch from 2522f78 to d82a355 Compare January 22, 2024 15:35
@zoddicus zoddicus merged commit bf17d88 into gpuweb:main Jan 22, 2024
1 check passed
@zoddicus zoddicus deleted the addFloorValidationTests branch January 22, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wgsl: Implement floor validation tests
2 participants