Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly expand image_copy tests to cover more snorm cases for compat #3260

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

shrekshao
Copy link
Contributor

@shrekshao shrekshao commented Jan 10, 2024

Issue: dawn/2314

Add some more cases to cover compat copy path for r8snorm, rg8snorm format.

Tests passed verified on Chrome linux vulkan.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@shrekshao shrekshao requested a review from greggman January 10, 2024 00:38
@shrekshao
Copy link
Contributor Author

Fix as discussed offline

@shrekshao
Copy link
Contributor Author

(Sorry... I just add one more test params: whether rowsPerImage === copyHeight)

Copy link
Contributor

@greggman greggman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shrekshao shrekshao enabled auto-merge (squash) January 10, 2024 19:32
@shrekshao shrekshao merged commit f136a75 into gpuweb:main Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants