-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update video files to improve external_texture* related cts coverage #3245
Conversation
This PR updated video files by referring webgl related cases here: https://github.com/KhronosGroup/WebGL/blob/main/sdk/tests/conformance/textures/misc/video-rotation.html#L112 The PR changes: - README.md with latest cmds to generate test video files. - Rotated video content. - Update video expected pixels values based on new test video files. - Related cts logic changes, including removing magic numbers. Fix:gpuweb#3232
Note this change fails tests due to implementation bugs. webgpu:web_platform,external_texture,video:importExternalTexture,compute:videoName="four-colors-h264-bt601-rotate-90.mp4";* webgpu:web_platform,copyToTexture,video:copy_from_video:videoName="four-colors-vp9-bt601-rotate-90.mp4";* webgpu:web_platform,copyToTexture,video:copy_from_video:videoName="four-colors-vp9-bt601-rotate-180.mp4";sourceType="VideoElement";srcDoFlipYDuringCopy=true;dstColorSpace="display-p3" webgpu:web_platform,copyToTexture,video:copy_from_video:videoName="four-colors-vp9-bt601-rotate-180.mp4";sourceType="VideoFrame";srcDoFlipYDuringCopy=true;dstColorSpace="display-p3" webgpu:web_platform,copyToTexture,video:copy_from_video:videoName="four-colors-vp9-bt601-rotate-180.mp4";sourceType="VideoFrame";srcDoFlipYDuringCopy=false;dstColorSpace="display-p3" webgpu:web_platform,copyToTexture,video:copy_from_video:videoName="four-colors-vp9-bt601-rotate-270.mp4";* webgpu:web_platform,copyToTexture,video:copy_from_video:videoName="four-colors-vp9-bt601-rotate-270.mp4";sourceType="VideoFrame";srcDoFlipYDuringCopy=true;dstColorSpace="display-p3" webgpu:web_platform,copyToTexture,video:copy_from_video:videoName="four-colors-vp9-bt601-rotate-270.mp4";sourceType="VideoFrame";srcDoFlipYDuringCopy=false;dstColorSpace="display-p3" |
I don't think I need to review since Corentin has already reviewed. (Skimmed it - looks good overall) Just for my knowledge - are we making / did we make a change in Chromium that will flip the rotation of rotated videos (for example vertical phone videos)? Technically this is breaking, though I don't think it's likely any application could have depended on this (they would have to know the rotation of the video in order to compensate for it, which isn't trivial afaik). Still we'll need to be cautious of it. |
I don't think we have any changes in chromium to flip the rotation of rotated videos unless the metadata(the transform matrix) guided us to do this. For the rotation changes, ffmpeg update the And in chromium, what we want to do is to ensure the Previous test cases are skipped on chromium CI due to h264 support issue. This PR add vp9 codec videos to fail the bots. |
@Kangz @kainino0x sry but pls don't merge this PR right now. After reading more chromium code, I think I still need to double check the order to apply rotate, visible rect and mirror. I'm seeking help on slack/media channel. |
Converted to draft to prevent landing. |
After some more investigation, I think I fully understand the order to apply visible_rect clipping, rotation (and mirror). The new video files contains both vertical videos and horizontal videos. Keep them for coverage. The cts has been updated based on this and update the comments to describe these steps. |
@kainino0x @Kangz sry but PTAL again. |
This PR updated video files by referring webgl related cases here: https://github.com/KhronosGroup/WebGL/blob/main/sdk/tests/conformance/textures/misc/video-rotation.html#L112
The PR changes:
Fixes #3232
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.