Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

val: Add depthSlice tests to render_pass_descriptor:color_attachments #3238

Merged
merged 6 commits into from
Jan 10, 2024

Conversation

haoxli
Copy link
Contributor

@haoxli haoxli commented Jan 4, 2024

Test depthSlice defined/undefined with special value, OOB, overlaps with mip levels in render pass's color attachments.

Issue: #3144


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@haoxli haoxli requested review from kainino0x and Kangz January 4, 2024 07:41
@haoxli haoxli enabled auto-merge (squash) January 10, 2024 00:59
@haoxli haoxli merged commit 873305a into gpuweb:main Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants