Compat: make atomicCompareExchangeWeak tests handle limits #3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greggman
requested review from
amaiorano,
ben-clayton and
shrekshao
and removed request for
amaiorano and
ben-clayton
shrekshao
approved these changes
Jan 5, 2024
| @@ -339,6 +339,11 @@ struct __atomic_compare_exchange_result<T> { | |||
| const numInvocations = t.params.workgroupSize; | |||
| const scalarType = t.params.scalarType; | |||
|
|
|||
| t.skipIf( | |||
There was a problem hiding this comment.
nit: maybe filter out the params instead of skipping in test body?
There was a problem hiding this comment.
Thanks for the suggestion. I don't think I can filter these out before without a device since I'm comparing to device.limits.maxComputeWorkgroupSizeX. I could hard code those limits somewhere but it seems better to look them up in the one place that would be correct in the future.
There was a problem hiding this comment.
No problem for leaving it as is then
greggman
force-pushed
the
compat-atomicCompareExchangeWeak
branch
from
86bb3da to
50920aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.