Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add readonly and readwrite storage textures as bindable resources #3219

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Add readonly and readwrite storage textures as bindable resources #3219

merged 3 commits into from
Dec 11, 2023

Conversation

Jiawei-Shao
Copy link
Collaborator

@Jiawei-Shao Jiawei-Shao commented Dec 8, 2023 •
edited by jiangzhaoming
Loading

This patch adds readonlyStorageTex, writeonlyStorageTex and readwriteStorageTex as ValidBindableResource and updates all the related tests to support them.

Issue: #3078

Requirements for PR author:

  • [*] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [*] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [*] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@Jiawei-Shao
Add readonly, writeonly and readwrite storage texture as bindable res…
2b02615 
…ources

This patch adds `readonlyStorageTex`, `writeonlyStorageTex` and
`readwriteStorageTex` as `ValidBinableResource` and updates all the
related tests to support them.
jiangzhaoming
jiangzhaoming approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@jiangzhaoming jiangzhaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

@Jiawei-Shao Jiawei-Shao merged commit 7a6ef73 into gpuweb:main Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiangzhaoming jiangzhaoming jiangzhaoming approved these changes

@Kangz Kangz Awaiting requested review from Kangz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jiawei-Shao @jiangzhaoming