Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test read-only and read-write storage texture in in_pass_encoder #3209

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

Jiawei-Shao
Copy link
Collaborator

This patch adds the tests on read-only and read-write storage textures in in_pass_encoder.spec.ts as the first part to test resource scope rules against all storage texture accesses.

Issue: #3078


Requirements for PR author:

  • [*] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [*] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [*] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

…c.ts

This patch adds the tests on read-only and read-write storage textures in
in_pass_encoder.spec.ts as the first part to test resource scope rules
against all storage texture accesses.
Copy link
Contributor

@jiangzhaoming jiangzhaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

@Jiawei-Shao Jiawei-Shao merged commit ab84ac7 into gpuweb:main Dec 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants