Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Rework how input domain domains are limited #3206

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

zoddicus
Copy link
Contributor

@zoddicus zoddicus commented Dec 5, 2023

Changes from wrap and forward pattern to have an optional utility function that returns the acceptable domains. This helps simplify reasoning about object lifetimes.

Fixes #3201


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@zoddicus zoddicus added the wgsl label Dec 5, 2023
@zoddicus zoddicus self-assigned this Dec 5, 2023
@zoddicus zoddicus force-pushed the fixDomainCheck branch 2 times, most recently from 2e528a7 to db5a341 Compare December 5, 2023 20:46
@zoddicus
Copy link
Contributor Author

zoddicus commented Dec 5, 2023

Rebased onto my cleanup PRs, to make my life a bit easier. All the new changes are in db5a341

Copy link
Contributor

@jiangzhaoming jiangzhaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

Changes from wrap and forward pattern to have an optional utility
function that returns the acceptable domains. This helps simplify
reasoning about object lifetimes.

Fixes gpuweb#3201
@zoddicus zoddicus merged commit 9de46a9 into gpuweb:main Dec 7, 2023
1 check passed
@zoddicus zoddicus deleted the fixDomainCheck branch December 7, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wgsl: Change domain restriction pattern for numeric framework
2 participants