Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat: Fix compat tests for depthOrArrayLayers restrictions #3204

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Dec 4, 2023

textureBindingViewDimension = '2d' must have depthOrArrayLayers = 1 textureBindingViewDimension = 'cube' must have depthOrArrayLayers = 6

For the createBindGroup test we just needed to skip when it's '2d' and not depthOrArrayLayers === 1

For the createTexture test we just need to pass in the correct depthOrArrayLayers for the given textureBindingViewDimension so we can test what we really want to test (textureBindingViewDimension vs dimension). The test below that tests depthOrArrayLayers vs textureBindingViewDimension


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

textureBindingViewDimension = '2d' must have depthOrArrayLayers = 1
textureBindingViewDimension = 'cube' must have depthOrArrayLayers = 6
@greggman greggman force-pushed the compat-fixes-for-depthOrArrayLayers branch from f7d1f88 to 8acb994 Compare December 4, 2023 22:55
@greggman greggman requested a review from shrekshao December 4, 2023 22:58
@greggman greggman enabled auto-merge (rebase) December 4, 2023 22:58
@greggman greggman merged commit 6590a34 into gpuweb:main Dec 4, 2023
1 check passed
@greggman greggman deleted the compat-fixes-for-depthOrArrayLayers branch December 4, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants