Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat: Fixes for format reinterpretation #3203

Merged

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Dec 4, 2023

format reinterpretation is not supported in compat mode. The format_reinterpretation tests already filter out every case where format == viewFormat so all that's left is cases that don't work in compat.

The createView tests test multiple combinations, some of which are valid and some are not.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@greggman greggman requested a review from shrekshao December 4, 2023 22:35
format reinterpretation is not supported in compat mode.
The format_reinterpretation tests already filter out every
case where format == viewFormat so all that's left is cases
that don't work in compat.

The createView tests test multiple combinations, some of which
are valid and some are not.
@greggman greggman force-pushed the compat-fixes-for-format-reinterpretation branch from 85e275d to d7a7f11 Compare December 4, 2023 22:40
@greggman greggman enabled auto-merge (rebase) December 4, 2023 22:40
@greggman greggman merged commit eb48ff8 into gpuweb:main Dec 4, 2023
1 check passed
@greggman greggman deleted the compat-fixes-for-format-reinterpretation branch December 4, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants