Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat: test depthOrArrayLayers vs textureBindingViewFormat #3198

Conversation

greggman
Copy link
Contributor

A texture with textureBindingViewFormat = '2d' should generate a validation error if depthOrArrayLayers is not 1

A texture with textureBindingViewFormat = 'cube' should generate a validation error if depthOrArrayLayers is not 6


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

A texture with textureBindingViewFormat = '2d' should generate
a validation error if depthOrArrayLayers is not 1

A texture with textureBindingViewFormat = 'cube' should generate
a validation error if depthOrArrayLayers is not 6
@greggman greggman requested a review from shrekshao November 30, 2023 23:17
@greggman greggman merged commit 1647569 into gpuweb:main Nov 30, 2023
1 check passed
@greggman greggman deleted the compat-depthOrArrayLayers-vs-textureBindingViewFormat branch November 30, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants