default entry points to shader modules #3190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beaufortfrancois
force-pushed
the
entrypoint
branch
3 times, most recently
from
91b8283 to
d929a05
Compare
kainino0x
reviewed
Nov 28, 2023
| .combine('shaderModuleStage', ['compute', 'vertex', 'fragment'] as TShaderStage[]) | ||
| .beginSubcases() | ||
| .combine('provideEntryPoint', [true, false]) | ||
| .combine('extraEntryPoint', [true, false]) |
There was a problem hiding this comment.
We also need to test different stages for the extraEntryPoint. For example a shader module with one vertex and one fragment stage should still be usable with default entry points.
This might be best as a separate test though, to avoid overparameterizing these tests for little extra coverage.
There was a problem hiding this comment.
Good catch!
beaufortfrancois
force-pushed
the
entrypoint
branch
from
d929a05 to
259242e
Compare
beaufortfrancois
force-pushed
the
entrypoint
branch
from
259242e to
393dfa7
Compare
|
FYI Chromium CL has landed in Chrome Canary. See https://chromiumdash.appspot.com/commit/61e85e41a5335013b0b33334efd5646baa9d9b0d |
kainino0x
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for gpuweb/gpuweb#4387
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.They're passing locally with my Chromium build patched with https://chromium-review.googlesource.com/c/chromium/src/+/5057294.
Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.