-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test CopyEI2T and GPUExternalTexture convert video contents to display-p3 color space #3189
Conversation
NOTE: this PR catches implemenation issues in chromium:
|
This PR refactor video related utils and add tests to cover GPUExternalTextureDescriptor:colorSpace = 'display-p3'.
Filled in issue #2362 above |
Almost forget to upload the excel |
@@ -165,7 +165,7 @@ export function displayP3ToSrgb(pixel: { R: number; G: number; B: number; A: num | |||
pixel.G = rgbVec[1]; | |||
pixel.B = rgbVec[2]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fix, I didn't realize this was mutating in place ^_^ We should make this take a readonly input.
I think you meant to remove these lines as well.
I will fix both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, sadly web_platform/util.ts
is a place where readonly types don't get enforced. Oh well, at least it would have caught these lines.
Thanks for the fix! |
This PR refactor video related utils and add tests to cover GPUExternalTextureDescriptor:colorSpace = 'display-p3'.
Issue: #2362
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.