Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat: fix createBindGroup validation test for compat #3153

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

greggman
Copy link
Contributor

In compat certain textureBindingViewDimemsion values must match the view dimension so skip tests when they don't

Note: That these cases are correctly rejected is tested in the webgpu:compat,* tests.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@greggman greggman requested a review from shrekshao November 10, 2023 07:47
In compat certain textureBindingViewDimemsion must match
the view dimension so skip tests when they don't

Note: That these cases are correctly rejected is tested
in the webgpu:compat,* tests.
@greggman greggman force-pushed the compat-fix-createBindGroup branch from 473a738 to 19bfc2b Compare November 11, 2023 00:58
@greggman greggman enabled auto-merge (rebase) November 11, 2023 00:58
@greggman greggman merged commit 7ca54d7 into gpuweb:main Nov 11, 2023
1 check passed
@greggman greggman deleted the compat-fix-createBindGroup branch November 11, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants