Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat: Fix texture_zero init tests for compat #3152

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

greggman
Copy link
Contributor

Fixes for texture_zero init tests in compat mode.

Issue: #3145


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@greggman greggman requested a review from shrekshao November 10, 2023 05:18
@greggman greggman enabled auto-merge (rebase) November 11, 2023 00:50
@greggman greggman force-pushed the compat-fix-texture-zero branch from a55c6e2 to 77c126d Compare November 11, 2023 00:51
@greggman greggman merged commit 180bf4b into gpuweb:main Nov 11, 2023
@greggman greggman deleted the compat-fix-texture-zero branch November 11, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants