Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat: copyTextureToTexture validation #3148

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Nov 9, 2023

Checks that you get a validation error of trying to copyT2T compressed textures in compat


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@greggman greggman requested a review from shrekshao November 9, 2023 03:08
@greggman greggman force-pushed the compat-t2t-validation branch from 96d5068 to b0244b9 Compare November 9, 2023 03:10
Copy link
Contributor

@shrekshao shrekshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a non-nit fix

@greggman greggman force-pushed the compat-t2t-validation branch from 4c76b5d to e75c38b Compare November 9, 2023 23:01
@greggman greggman enabled auto-merge (rebase) November 9, 2023 23:01
@greggman greggman merged commit 0002419 into gpuweb:main Nov 9, 2023
1 check passed
@greggman greggman deleted the compat-t2t-validation branch November 1, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants