Remove preview workflow, do WPT lint in PR workflow #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The artifact upload for the PR preview workflow was really slow. We could re-enable this if we find it's needed though. The WPT lint workflow was doing a redundant build of most of the CTS. We can just run WPT's lint after a regular build (it seems to take only 2 seconds on past runs).
mehmetoguzderin
approved these changes
Nov 2, 2023
|
Yes, I was thinking that too. Sounds good. BTW, I forgot to mention in the PR - the CTS preview also hasn't been working (posting GitHub comments) for at least a few days. Guessing that switching to the new solution would work better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The artifact upload for the PR preview workflow was really slow. We could re-enable this if we find it's needed though.
The WPT lint workflow was doing a redundant build of most of the CTS. We can just run WPT's lint after a regular build (it seems to take only 11+2 seconds on past runs, including the one on this PR).
Issue: None
Requirements for PR author: N/A
Requirements for reviewer sign-off: N/A