Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore missing test path validation #3129

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Nov 2, 2023

This fixes tools/validate so it actually does all the validation it was supposed to do. Also deduplicates recently-introduced (benign) duplicate subcases that it would have caught.

I inadvertently removed the check in #2770.

Issue: None


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

This fixes tools/validate so it actually does all the validation it was
supposed to do. Also deduplicates recently-introduced (benign) duplicate
subcases that it would have caught.

Accidentally regressed in gpuweb#2770.
@kainino0x kainino0x requested a review from greggman November 2, 2023 05:31
@kainino0x kainino0x requested a review from zoddicus November 2, 2023 05:37
Copy link
Contributor

@greggman greggman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kainino0x kainino0x merged commit d13a52a into gpuweb:main Nov 2, 2023
2 checks passed
@kainino0x kainino0x deleted the validate branch November 2, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants