Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Double Runs and make run clearer. #3124

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Nov 1, 2023

Prevents clicking a run button while tests are running. I seem to do this once in a while and get errors about DevicePool acquire device in use 😅

Also made the progress bar have a background color so it's slightly clearer that tests are running.

@greggman greggman requested a review from toji November 1, 2023 04:48
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've definitely hit this problem several times.

Prevents clicking a run button while tests are running.
I seem to do this once in a while and get errors about DevicePool
acquire device in use 😅

Also made the progress bar have a background color so it's slightly
clearer that tests are running.
@greggman greggman force-pushed the prevent-double-runs branch from 1df0874 to faa4cac Compare November 1, 2023 23:06
@greggman greggman enabled auto-merge (rebase) November 1, 2023 23:06
@greggman greggman merged commit 0fac55f into gpuweb:main Nov 1, 2023
2 checks passed
@greggman greggman deleted the prevent-double-runs branch November 2, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants