Optimize some checkElements* implementations #3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... instead of by calling into checkElementsPassPredicate.
lokokung
approved these changes
Nov 1, 2023
| @@ -44,7 +44,28 @@ export function checkElementsEqual( | |||
| ): ErrorWithExtra | undefined { | |||
| assert(actual.constructor === expected.constructor, 'TypedArray type mismatch'); | |||
| assert(actual.length === expected.length, 'size mismatch'); | |||
| return checkElementsEqualGenerated(actual, i => expected[i]); | |||
There was a problem hiding this comment.
Hmmm... I would be interested to see if the change here where instead of creating an additional generator, we are now just comparing the arrays is the real culprit of the speed up? (Sort of the only thing that seems to really have changed functionally?)
There was a problem hiding this comment.
I measured these changes separately - see the commit messages. The largest speedup was from just splitting the check function in half.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webgpu:api,operation,command_buffer,copyTextureToTexture:*accounts for a huge chunk of the api,operation test time (maybe 25%). This makes it almost 40% faster on my machine (13.5s -> 8.5s).Most of the speedup is just from splitting the failure case code out into a different function. This must impact inlining or something in V8; unfortunately I suspect the improvement wouldn't translate directly to other JS engines.
Those tests could probably also use some parameterization reduction, but I'll do that separately.
Issue: None
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.