Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache files being padded with trailing 0's #3121

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

ben-clayton
Copy link
Contributor

@ben-clayton ben-clayton commented Oct 31, 2023

buffer() was offsetting the array instead of truncating the returned array.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

buffer() was offseting the array instead of truncating the returned
array.
@ben-clayton
Copy link
Contributor Author

Local testing looks good. Landing.

@ben-clayton ben-clayton merged commit 2f3b68c into gpuweb:main Oct 31, 2023
2 checks passed
@ben-clayton ben-clayton deleted the fix-cache-size branch October 31, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants