Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Convert quantizeToF32 to used Math.fround #3119

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

zoddicus
Copy link
Contributor

Instead of passing the input through a F32Array, use the builtin Math.fround.

This leads to a ~5% improvement benchmarking locally. This is less than the equivalent f16 change, because F32Array is provided by the runtime, whereas F16Array is being polyfilled, so is probably more efficient to begin with.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@zoddicus zoddicus added enhancement New feature or request wgsl labels Oct 31, 2023
@zoddicus zoddicus self-assigned this Oct 31, 2023
Instead of passing the input through a F32Array, use the builtin
Math.fround.

This leads to a ~5% improvement benchmarking locally. This is less
than the equivalent f16 change, because F32Array is provided by the
runtime, whereas F16Array is being polyfilled, so is probably more
efficient to begin with.
@zoddicus zoddicus enabled auto-merge (squash) October 31, 2023 20:55
@zoddicus zoddicus merged commit cb5b33c into gpuweb:main Oct 31, 2023
2 checks passed
@zoddicus zoddicus deleted the usefround branch October 31, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wgsl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants