Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev_server: Serve on localhost by default #3115

Merged
merged 4 commits into from
Oct 31, 2023
Merged

Conversation

kainino0x
Copy link
Collaborator

Binding 127.0.0.1 avoids unexpectedly exposing the dev server over the network when the port is not protected by a firewall.

Issue: None


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@kainino0x kainino0x requested a review from austinEng October 31, 2023 01:26
@kainino0x kainino0x enabled auto-merge (squash) October 31, 2023 17:57
@kainino0x kainino0x merged commit ccee5a9 into gpuweb:main Oct 31, 2023
2 checks passed
@kainino0x kainino0x deleted the localhost branch October 31, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants