Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details about 'atleast as good as f32' for AbstractFloats #3112

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

zoddicus
Copy link
Contributor

This also removes a dead link

Fixes #3111


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@zoddicus zoddicus self-assigned this Oct 30, 2023
@github-actions
Copy link

Previews, as seen when this build job started (ad313e7):
Run tests | View tsdoc

Copy link
Collaborator

@kainino0x kainino0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not that familiar with either FPTraits or the WGSL spec here, but otherwise LGTM

docs/fp_primer.md Outdated Show resolved Hide resolved
docs/fp_primer.md Outdated Show resolved Hide resolved
docs/fp_primer.md Outdated Show resolved Hide resolved
Copy link

Previews, as seen when this build job started (a2dee73):
Run tests | View tsdoc

Copy link
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is explained very well. Thank you!

docs/fp_primer.md Outdated Show resolved Hide resolved
@zoddicus zoddicus merged commit c443ee7 into gpuweb:main Nov 2, 2023
1 check passed
@zoddicus zoddicus deleted the updateFPPrimer branch November 2, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add discussion of AbstractFloat behaviour to fp_primer.md
3 participants