Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BinaryStream: Use little endian for f64 #3108

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

ben-clayton
Copy link
Contributor

To match all the other data types


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

To match all the other data types
@ben-clayton ben-clayton requested a review from austinEng October 27, 2023 15:40
@ben-clayton
Copy link
Contributor Author

Doesn't really affect anything - just an inconsistency

@ben-clayton ben-clayton merged commit 2ef3f32 into gpuweb:main Oct 27, 2023
2 checks passed
@ben-clayton ben-clayton deleted the little-endian-f64 branch October 27, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants