Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use largest maxInterStageShaderVariables in maxInterStageShaderCompon… #3104

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

Jiawei-Shao
Copy link
Collaborator

…ents tests

This patch uses the largest value of maxInterStageShaderVariables supported on current adapter in the tests about maxInterStageShaderComponents when creating devices so that when the value we use as maxInterStageShaderComponents is larger than the default one, we won't be limited by the default value of maxInterStageShaderVariables.

This patch also removes the assertion that the value of maxInterStageShaderVariables must be larger than a quarter of maxInterStageShaderComponents as on many backends the largest value of maxInterStageShaderComponents is equal to 4x maxInterStageShaderVaraibles, so in "overLimit" tests the value of maxInterStageShaderComponents can be greater than 4x device.limits.maxInterStageShaderVaraibles.

Issue: #2195


Requirements for PR author:

  • [*] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [*] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [*] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

…ents tests

This patch uses the largest value of maxInterStageShaderVariables supported on
current adapter in the tests about maxInterStageShaderComponents when
creating devices so that when the value we use as maxInterStageShaderComponents
is larger than the default one, we won't be limited by the default value of
maxInterStageShaderVariables.

This patch also removes the assertion that the value of
maxInterStageShaderVariables must be larger than a quarter of
maxInterStageShaderComponents as on many backends the largest value of
maxInterStageShaderComponents is equal to 4x maxInterStageShaderVaraibles, so
in "overLimit" tests the value of maxInterStageShaderComponents can be greater
than 4x device.limits.maxInterStageShaderVaraibles.
@github-actions
Copy link

Previews, as seen when this build job started (bedab90):
Run tests | View tsdoc

Copy link
Contributor

@jiangzhaoming jiangzhaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

@Jiawei-Shao Jiawei-Shao merged commit 36a23bf into gpuweb:main Oct 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants