New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate definitions of reinterpret* #3095

Merged

austinEng merged 1 commit into gpuweb:main from austinEng:redundant-reinterpret

Oct 25, 2023

Collaborator

austinEng commented Oct 25, 2023

Issue: #

Requirements for PR author:

All missing test coverage is tracked with "TODO" or .unimplemented().
New helpers are /** documented */ and new helper files are found in helper_index.txt.
Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

Tests are properly located in the test tree.
Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.


          Remove duplicate definitions of reinterpret*

f37b46d

austinEng requested a review from zoddicus

October 25, 2023 19:45

github-actions bot commented Oct 25, 2023

Previews, as seen when this build job started (f37b46d):
Run tests | View tsdoc

zoddicus approved these changes

View reviewed changes

austinEng merged commit 2be0e90 into gpuweb:main

2 checks passed

austinEng deleted the redundant-reinterpret branch

October 25, 2023 20:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet