Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slim down on typed array allocations in conversion.ts #3092

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

austinEng
Copy link
Collaborator

@austinEng austinEng commented Oct 25, 2023

Improves deserialization from the case cache by at least 2x, with fewer GC events.

Issue: #


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@github-actions
Copy link

Previews, as seen when this build job started (a43fb25):
Run tests | View tsdoc

@github-actions
Copy link

Previews, as seen when this build job started (f87055f):
Run tests | View tsdoc

Copy link
Contributor

@ben-clayton ben-clayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval with nits

src/webgpu/util/conversion.ts Show resolved Hide resolved
src/webgpu/util/conversion.ts Outdated Show resolved Hide resolved
src/webgpu/util/conversion.ts Show resolved Hide resolved
@github-actions
Copy link

Previews, as seen when this build job started (e4b1a6c):
Run tests | View tsdoc

@ben-clayton
Copy link
Contributor

LGTM

@austinEng austinEng merged commit 42e6b6d into gpuweb:main Oct 25, 2023
2 checks passed
@austinEng austinEng deleted the typed-array-opt branch October 25, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants