wgsl: Add AbstractFloat mix execution tests
#3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previews, as seen when this build job started (de68a79): |
jiangzhaoming
approved these changes
Oct 25, 2023
src/unittests/floating_point.spec.ts
Outdated
| { input: [-1.0, 1.0, 0.9], expected: 0.8 }, | ||
|
|
||
| // Showing how precise and imprecise versions diff | ||
| // Note that this expectation is 0 in f64 as 10.0 is much smaller that f63.negative.min, |
There was a problem hiding this comment.
Suggested change
| // Note that this expectation is 0 in f64 as 10.0 is much smaller that f63.negative.min, | |
| // Note that this expectation is 0 in f64 as 10.0 is much smaller that f64.negative.min, |
| t.params, | ||
| cases | ||
| ); | ||
| }); | ||
| g.test('abstract_float_nonmatching_vec2') |
There was a problem hiding this comment.
nit: Add an empty line here
| .unimplemented(); | ||
| .params(u => u.combine('inputSource', onlyConstInputSource)) | ||
| .fn(async t => { | ||
| const cases = await d.get('abstract_vec3_scalar'); |
There was a problem hiding this comment.
Suggested change
| const cases = await d.get('abstract_vec3_scalar'); | |
| const cases = await d.get('abstract_vec4_scalar'); |
And also the types below
|
FYI, I am going to delay landing this for a while, since Dawn is currently working on some CTS running issues, and I think this would just be more fuel on that fire. |
ben-clayton
reviewed
Nov 3, 2023
src/unittests/floating_point.spec.ts
Outdated
| @@ -5342,10 +5342,9 @@ const kMixImpreciseIntervalCases = { | |||
| { input: [-1.0, 1.0, 0.9], expected: [reinterpretU64AsF64(0x3fe9_9999_8000_0000n), reinterpretU64AsF64(0x3fe9_9999_c000_0000n)] }, // ~0.8 | |||
|
|
|||
| // Showing how precise and imprecise versions diff | |||
| // Note that this expectation is 0 only in f32 as 10.0 is much smaller that f32.negative.min, | |||
| // Note that this expectation is 0 in f32 as 10.0 is much smaller that f32.negative.min, | |||
| // So that 10 - f32.negative.min == f32.negative.min even in f64. But for f16, there is not | |||
There was a problem hiding this comment.
10 - f32.negative.min is -f32.negative.min, no?
src/unittests/floating_point.spec.ts
Outdated
| // So that 10 - f32.negative.min == f32.negative.min even in f64. But for f16, there is not | ||
| // a exactly-represenatble f16 value v that make v - f16.negative.min == f16.negative.min | ||
| // in f64, in fact that require v being smaller than 2**-37. | ||
| // an exactly-represenatble f16 value v that make v - f16.negative.min == f16.negative.min |
src/unittests/floating_point.spec.ts
Outdated
| // So that 10 - f32.negative.min == f32.negative.min even in f64. But for f16, there is not | ||
| // a exactly-represenatble f16 value v that make v - f16.negative.min == f16.negative.min | ||
| // in f64, in fact that require v being smaller than 2**-37. | ||
| // an exactly-represenatble f16 value v that make v - f16.negative.min == f16.negative.min | ||
| { input: [kValue.f32.negative.min, 10.0, 1.0], expected: 0.0 }, |
There was a problem hiding this comment.
Would be nice to see some cases with 1.0 changed to something more than and less than 1.0
zoddicus
force-pushed
the
addAFMixTests
branch
from
de68a79 to
f344018
Compare
zoddicus
force-pushed
the
addAFMixTests
branch
3 times, most recently
from
5249a6d to
7fa5be9
Compare
zoddicus
force-pushed
the
addAFMixTests
branch
from
7fa5be9 to
9921301
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2566
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.