Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pipeline statistics query tests #3085

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Remove pipeline statistics query tests #3085

merged 1 commit into from
Oct 24, 2023

Conversation

beaufortfrancois
Copy link
Collaborator

@beaufortfrancois beaufortfrancois commented Oct 24, 2023

This PR removes pipeline statistics query tests as it's not part of the WebGPU spec.

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@github-actions
Copy link

Previews, as seen when this build job started (f866762):
Run tests | View tsdoc

@github-actions
Copy link

Previews, as seen when this build job started (a8391fa):
Run tests | View tsdoc

@kainino0x
Copy link
Collaborator

kainino0x commented Oct 24, 2023

I'm surprised you didn't have to remove it from capability_info.ts (it's already not there). I guess some of these test descriptions were wrong and they weren't even testing pipeline statistics queries to begin with.

@kainino0x kainino0x merged commit 8e7a995 into main Oct 24, 2023
2 checks passed
@kainino0x kainino0x deleted the remove-psq branch October 24, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants