Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Cleanup cruft related to quantizeToF16 #3082

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

zoddicus
Copy link
Contributor

This is only defined for f32, so doesn't really need to be defined in the other classes that will never implement it.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

This is only defined for f32, so doesn't really need to be defined in
the common super class. This allows for removing the various stub
references to it, that will never be implemented.
@zoddicus zoddicus added the wgsl label Oct 23, 2023
@zoddicus zoddicus self-assigned this Oct 23, 2023
@github-actions
Copy link

Previews, as seen when this build job started (55e144b):
Run tests | View tsdoc

Copy link
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I saw there was an assertion for code that would have invoked a test for quantizeToF16 for a non-f32 based argument. But that seems to not be exercised.
I concluded this was fine because the assert itself was never triggered (otherwise the TS copmijle would fail). It would be some other test or MR that would check for a validation failure. So, after all, this is fine.

@zoddicus zoddicus merged commit 199c8f1 into gpuweb:main Oct 25, 2023
2 checks passed
@zoddicus zoddicus deleted the removeAFQuantizeToF16Stub branch October 25, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants