Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgsl: Add AbstractFloat sign execution tests #3081

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

zoddicus
Copy link
Contributor

Fixes #2582


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@zoddicus zoddicus added the wgsl label Oct 23, 2023
@zoddicus zoddicus self-assigned this Oct 23, 2023
Copy link
Contributor

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -1356,7 +1356,7 @@
"webgpu:shader,execution,expression,call,builtin,saturate:f32:*": { "subcaseMS": 116.275 },
"webgpu:shader,execution,expression,call,builtin,select:scalar:*": { "subcaseMS": 6.882 },
"webgpu:shader,execution,expression,call,builtin,select:vector:*": { "subcaseMS": 7.096 },
"webgpu:shader,execution,expression,call,builtin,sign:abstract_float:*": { "subcaseMS": 31.708 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Does this actually need to be added? When I read the docs a couple of weeks ago I thought the actual numbers were updated by some other process at some time.

Copy link
Contributor Author

@zoddicus zoddicus Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not aware of a process that updates them.
Are you thinking of the steps in adding_timing_metadata.md that describe using the tooling to update things instead of manually editing the file? (That is what I did)

I have updated these tests, since they are going from being a no-op .unimplemented() to actually running code, so the runtime will likely be significantly longer now.

When just fixing a bug in a test, I generally don't update the values, unless I have reason to think the estimate will change significant.

@github-actions
Copy link

Previews, as seen when this build job started (ec32af8):
Run tests | View tsdoc

@zoddicus zoddicus merged commit 2499ea9 into gpuweb:main Oct 23, 2023
2 checks passed
@zoddicus zoddicus deleted the addAFSignTests branch October 23, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wgsl: AbstractFloat execution tests for sign builtin
2 participants