Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slightly expand sample_mask tests #2466

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Slightly expand sample_mask tests #2466

merged 2 commits into from
Mar 28, 2023

Conversation

kainino0x
Copy link
Collaborator

@kainino0x kainino0x commented Mar 25, 2023 •
edited
Loading

  • Tighten the rasterized primitives around the standard sample locations as a test that they're in the exact places we expect.
  • Parameterize by whether UV is interpolated or not. The non-interpolated fragment_output_mask tests now pass on Mali, but alpha_to_coverage tests still all fail, but we don't know why.

Issue: #2201, #2146, inline spec issue about standard sample locations https://gpuweb.github.io/gpuweb/#issue-3dbf56b0

Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@kainino0x
Slightly expand sample_mask tests
e0cffd7 
- Tighten the rasterized primitives around the standard sample locations
  as a test that they're in the exact places we expect.
- Parameterize by whether UV is interpolated or not. The
  non-interpolated fragment_output_mask tests now pass on Mali, but
  alpha_to_coverage tests still all fail, but we don't know why.
@kainino0x kainino0x requested a review from shrekshao March 25, 2023 02:06
@github-actions
Copy link

Previews, as seen when this build job started (e0cffd7):
Run tests | View tsdoc

@kainino0x kainino0x mentioned this pull request Mar 27, 2023
Closed
shrekshao
shrekshao approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@shrekshao shrekshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit comments

src/webgpu/api/operation/render_pipeline/sample_mask.spec.ts Outdated Show resolved Hide resolved
src/webgpu/api/operation/render_pipeline/sample_mask.spec.ts Outdated Show resolved Hide resolved
@kainino0x kainino0x enabled auto-merge (squash) March 28, 2023 05:02
@kainino0x kainino0x merged commit fd777c3 into gpuweb:main Mar 28, 2023
@github-actions
Copy link

Previews, as seen when this build job started (bb75775):
Run tests | View tsdoc

ErichDonGubler pushed a commit to mozilla/gpuweb-cts that referenced this pull request Aug 16, 2023
@kainino0x @ErichDonGubler
Slightly expand sample_mask tests (gpuweb#2466)
4bd1220 
* Slightly expand sample_mask tests

- Tighten the rasterized primitives around the standard sample locations
  as a test that they're in the exact places we expect.
- Parameterize by whether UV is interpolated or not. The
  non-interpolated fragment_output_mask tests now pass on Mali, but
  alpha_to_coverage tests still all fail, but we don't know why.

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrekshao shrekshao shrekshao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kainino0x @shrekshao