op,render_pipeline,alpha_to_coverage #2202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2201
Add the alphaToCoverage mask tests.
Remove the
src/webgpu/api/operation/render_pipeline/alpha_to_coverage.spec.ts
stub and put tests undersrc/webgpu/api/operation/render_pipeline/sample_mask.spec.ts
to share code.The algorithm of producing the alpha-to-coverage mask is platform-dependent. And the requirement of alphaToCoverage mask of alpha where 0 < alpha < 1 is only that the mask bits should be non-decreasing.
So instead of putting alpha = { < 0, = 0, = 1/16, = 2/16, ..., = 15/16, = 1, > 1 } in params subcases, put them inside the test. Draw and readback the value for each alpha value. Iterate through them and compare the result value with that of the previous alpha value (alpha'). Check if the result is non-decreasing for each component (for color, stencil), or non-increasing if the value is in negative-correlation to the alpha mask (depth)
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.