Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move builtin must_use tests into per-builtin validation suites #3502

Closed
jrprice opened this issue Mar 14, 2024 · 1 comment · Fixed by #3745
Closed

Move builtin must_use tests into per-builtin validation suites #3502

jrprice opened this issue Mar 14, 2024 · 1 comment · Fixed by #3745
Assignees
@dneto0
Labels
wgsl

Comments

@jrprice
Copy link
Contributor

jrprice commented Mar 14, 2024

We have tests that the results of most builtins must be used in must_use.spec.ts, but we have also started adding equivalent tests inside the per-builtin validation suites, e.g. #3496.

We should probably move all of these must_use tests into the per-builtin suites to make it clearer what should be covered when adding a new builtin. The dedicated must_use suite would then focus on user-specified @must_use attributes.
@jrprice jrprice added the wgsl label Mar 14, 2024
@dneto0 dneto0 mentioned this issue Mar 14, 2024
Merged
8 tasks
@alan-baker
Copy link
Contributor

Don't neglect src/webgpu/shader/validation/expression/call/builtin/value_constructor.spec.ts.

@alan-baker alan-baker mentioned this issue May 7, 2024
Closed
alan-baker added a commit to alan-baker/webgpu-cts that referenced this issue May 14, 2024
@alan-baker
Move builtin must_use tests to specific builtin tests
36e7570 
Fixes gpuweb#3502

* Moves must_use tests for builtin functions to specific files
@alan-baker alan-baker mentioned this issue May 14, 2024
Merged
8 tasks
alan-baker added a commit to alan-baker/webgpu-cts that referenced this issue May 15, 2024
@alan-baker
Move builtin must_use tests to specific builtin tests
749cf1b 
Fixes gpuweb#3502

* Moves must_use tests for builtin functions to specific files
alan-baker added a commit that referenced this issue May 15, 2024
@alan-baker
Move builtin must_use tests to specific builtin tests (#3745)
938c911 
Fixes #3502

* Moves must_use tests for builtin functions to specific files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dneto0 dneto0

Labels
wgsl
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move builtin must_use tests to specific builtin tests alan-baker/webgpu-cts
4 participants
@jrprice @dneto0 @alan-baker and others