Skip to content

Commit

Permalink
vertex_buffer_OOB: more subcases per case
Browse files Browse the repository at this point in the history
This helps a lot in standalone (18s -> 12s) but it probably won't help
quite as much in other modes.
  • Loading branch information
kainino0x committed Oct 31, 2023
1 parent 232a922 commit a536eb1
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/webgpu/api/validation/encoding/cmds/render/draw.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -408,15 +408,15 @@ success/error as expected. Such set of buffer parameters should include cases li
.combine('VBSize', ['zero', 'exile', 'enough'] as const)
// the state of instance step mode vertex buffer bound size
.combine('IBSize', ['zero', 'exile', 'enough'] as const)
// the state of array stride
.combine('AStride', ['zero', 'exact', 'oversize'] as const)
.beginSubcases()
// should the vertex stride count be zero
.combine('VStride0', [false, true] as const)
// should the instance stride count be zero
.combine('IStride0', [false, true] as const)
// the state of array stride
.combine('AStride', ['zero', 'exact', 'oversize'] as const)
// the factor for offset of attributes in vertex layout
.combine('offset', [0, 1, 2, 7]) // the offset of attribute will be factor * MIN(4, sizeof(vertexFormat))
.beginSubcases()
.combine('setBufferOffset', [200]) // must be a multiple of 4
.combine('attributeFormat', ['snorm8x2', 'float32', 'float16x4'] as GPUVertexFormat[])
.expandWithParams(p =>
Expand Down

0 comments on commit a536eb1

Please sign in to comment.