Texture Utils, log bad weights only if debugging (#4073)

gpuweb · Dec 5, 2024 · 79e72c0 · 79e72c0
1 parent 096f9fd
commit 79e72c0
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/webgpu/shader/execution/expression/call/builtin/texture_utils.ts b/src/webgpu/shader/execution/expression/call/builtin/texture_utils.ts
@@ -263,14 +263,16 @@ export function graphWeights(height: number, weights: number[]) {
 /**
  * Validates the weights go from 0 to 1 in increasing order.
  */
-function validateWeights(stage: string, weights: number[]) {
-  const showWeights = () => `
+function validateWeights(t: GPUTest, stage: string, weights: number[]) {
+  const showWeights = t.rec.debugging
+    ? () => `
 ${weights.map((v, i) => `${i.toString().padStart(2)}: ${v}`).join('\n')}
 
 e = expected
 A = actual
 ${graphWeights(32, weights)}
-`;
+`
+    : () => ``;
 
   // Validate the weights
   assert(
@@ -586,8 +588,8 @@ export async function queryMipLevelMixWeightsForDevice(t: GPUTest, stage: Shader
 
   const [sampleLevelWeights, gradWeights] = unzip(result, kNumWeightTypes, 4);
 
-  validateWeights(stage, sampleLevelWeights);
-  validateWeights(stage, gradWeights);
+  validateWeights(t, stage, sampleLevelWeights);
+  validateWeights(t, stage, gradWeights);
 
   texture.destroy();
   storageBuffer.destroy();